Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap sass instead of Bootstrap css #27

Closed
abhinavsachdeva2701 opened this issue Nov 10, 2017 · 1 comment
Closed

Bootstrap sass instead of Bootstrap css #27

abhinavsachdeva2701 opened this issue Nov 10, 2017 · 1 comment
Assignees

Comments

@abhinavsachdeva2701
Copy link

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[x ] Support request

Current behavior

In Angular-cli.json file, instead of pointing to bootstrap css, if it is pointed to bootstrap sass, amexio components are not rendering properly. In angular-cli.json i have included
"styles": [
"assets/styles/vendor.scss",
"assets/styles/styles.scss",

vendor.scss consist of
$icon-font-path: "~bootstrap-sass/assets/fonts/bootstrap/";
@import
'~bootstrap-sass/assets/stylesheets/bootstrap';

By this way amexio components are not rendering properly. Even after including bootstrap sass do i need to still include bootstrap css

Expected behavior

Components should render properly with bootstrap sass

Minimal reproduction of the problem with instructions

For bug reports please provide the STEPS TO REPRODUCE and if possible a MINIMAL DEMO of the problem via
https://plnkr.co or similar (you can use Our Amexio Plunker as a starting point: http://plnkr.co/edit/M9AeGH?p=info)

What is the motivation / use case for changing the behavior?

I am using amexio component for developing production application, and since we are using bootstrap 4 which is made up in sass(scss), i only want to point to bootstrap sass like this in a scss file and include this scss file in angular-cli.json
$icon-font-path: "~bootstrap-sass/assets/fonts/bootstrap/";
@import
'~bootstrap-sass/assets/stylesheets/bootstrap';

Environment


Angular version: X.Y.Z

Angular 2
Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

@DatsGawas
Copy link

Which Angular CLI Version are you using ? As older versions of CLI needed to set a explicit flag for SCSS
ng set defaults.styleExt scss . We have reproduced the issue and set the angular-cli.json to

"styles": [
"../node_modules/bootstrap/scss/bootstrap.scss",
"assets/styles/styles.scss",
]

And Found no issue's.
Angular CLI Version : 1.4.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants