Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap Only Subgraphs - Ensure all nested values are created #2385

Closed
melotik opened this issue Sep 26, 2023 · 0 comments · Fixed by #2386
Closed

Swap Only Subgraphs - Ensure all nested values are created #2385

melotik opened this issue Sep 26, 2023 · 0 comments · Fixed by #2386
Assignees
Labels
p0 high priority

Comments

@melotik
Copy link
Contributor

melotik commented Sep 26, 2023

For all swap-only subgraphs all nested entities need to be created (with ID only at least).

Acceptance criteria (should be able to make this query):

query MyQuery {
  swaps {
     account {
       id
     }
    pool {
      id
    }
    protocol {
      id
    }
    tokenIn {
      id
    }
    tokenOut {
      id
    }
  }
}

Notes: For most of subgaphs, the only entity that needs to be added is account

See: pancakeswap

@melotik melotik added the p0 high priority label Sep 26, 2023
@melotik melotik moved this from Discussions to Assigned for Fixes in Subgraph Development Sep 26, 2023
@dhruv-chauhan dhruv-chauhan moved this from Assigned for Fixes to Ready for Review in Subgraph Development Sep 27, 2023
@github-project-automation github-project-automation bot moved this from Ready for Review to Deploy To Hosted Service in Subgraph Development Sep 27, 2023
@bye43 bye43 moved this from Deploy To Hosted Service to Done in Subgraph Development Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p0 high priority
Projects
Development

Successfully merging a pull request may close this issue.

2 participants