Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build friend.tech subgraph #2372

Closed
2 tasks done
melotik opened this issue Sep 14, 2023 · 5 comments · Fixed by #2384
Closed
2 tasks done

Build friend.tech subgraph #2372

melotik opened this issue Sep 14, 2023 · 5 comments · Fixed by #2384
Assignees
Labels
new subgraph p1 medium priority

Comments

@melotik
Copy link
Contributor

melotik commented Sep 14, 2023

https://www.friend.tech/

Tasks

Preview Give feedback
@melotik melotik added p1 medium priority new subgraph labels Sep 14, 2023
@melotik melotik moved this from Discussions to Assigned for Fixes in Subgraph Development Sep 14, 2023
@bye43 bye43 moved this from Assigned for Fixes to In Progress in Subgraph Development Sep 25, 2023
@dhruv-chauhan dhruv-chauhan moved this from In Progress to Ready for Review in Subgraph Development Sep 28, 2023
@dhruv-chauhan dhruv-chauhan linked a pull request Sep 28, 2023 that will close this issue
8 tasks
@bye43
Copy link
Contributor

bye43 commented Oct 11, 2023

@dhruv-chauhan Going through some metrics still, but a few QA comments (these may or not be issues, but figured I would let you know)

  • The TVL is about 17% different than defiLlama and it looks like this starts around 09/13
    Image

  • The daily active buyers (which also means users) seem to be less than what Dune and Token Terminal are reporting 35K on the largest spike and we are reporting around 21K
    Image
    Image

  • The buy and sell volumes seem to be different than this Dune too
    Image
    Image

  • The trader and subject stats also seem to be slightly off when I am comparing this query to the Friend.Tech Subject Stats module on this Dune dashboard. Will list some differences I am seeing below:

trader: 0xef5391a73e2cb70ae0435b4395a8db4beaec1934

Metrics Subgraph Dune
Buy Count 2335 2218
Sell Count 680 339
Total Volume (ETH) 1270 1161
Buy Volume (ETH) 754 709
Sell Volume (ETH) 516 451

subject: 0x730905a69bbd316e2a39bdf22dd866b6d97625fe

Metrics Subgraph Dune
Share Price 28.73 1.26
Buy Count 13 13
Sell Count 1 1

@bye43 bye43 moved this from Ready for Review to In Review in Subgraph Development Oct 11, 2023
@bye43
Copy link
Contributor

bye43 commented Nov 18, 2023

@dhruv-chauhan the buy and sell volume still looks off on the newer version. And did we remove the traders and subjects entities? If so, was there a reason?

@bye43 bye43 moved this from In Review to In Progress in Subgraph Development Nov 18, 2023
@dhruv-chauhan
Copy link
Collaborator

  • Buy and Sell Volume:
    I think the reading on the graphs are a bit different due to timezone difference on calculating days, since the pattern and ranges otherwise look similar. Also, the cumulative of these volumes match the dune dashboard: [query]
Metrics Dune Subgraph
Cumulative Buy Volume (USD) 265,857,07 265821697.556003351078125
Cumulative Sell Volume (USD) 242,876,149 242733890.176980244245
Cumulative Total Volume (USD) 508,495,454 508555587.732983595323125
  • Trader and Subject Stats:
    Yes, we changed Trader and Subject entities to Account and Pool respectively to match the generic schema.
    Also note, each subject is a trader; but, a trader does not compulsorily have to be a subject. For each address, there might be a Pool and an Account entity.

address: 0xef5391a73e2cb70ae0435b4395a8db4beaec1934

Pool (subject) Stats [query],

Metrics Dune Subgraph
Buy Count 519 521
Buy Volume (Eth) 818.4754 818.475437500000000000
Sell Count 390 391
Sell Volume (Eth) 773.2314 773.231375000000000000
Total Volume (Eth) 1.5917k 1591.706812500000000000
Share Price (Eth) 1.05625 1.056250000000000000
Supply 130 130
Fee (USD) 134.04k 133956.35218445184109375

Account (trader) Stats [query]

address: 0x730905a69bbd316e2a39bdf22dd866b6d97625fe

Pool (subject) Stats [query],

Metrics Dune Subgraph
Buy Count 14 14
Buy Volume (Eth) 88.1353 88.135312500000000000
Sell Count 4 4
Sell Volume (Eth) 78.4381 78.438125000000000000
Total Volume (Eth) 166.5734 166.573437500000000000
Share Price (Eth) 0.38025 0.380250000000000000
Supply 78 78
Fee (USD) 13.52k 13516.209728405909375

As Account (trader) [query]

@bye43

@bye43
Copy link
Contributor

bye43 commented Nov 28, 2023

O I see that makes sense. Thanks for the explanation! This looks good to me then. Closing this out

@bye43 bye43 closed this as completed Nov 28, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Deploy To Hosted Service in Subgraph Development Nov 28, 2023
@dhruv-chauhan
Copy link
Collaborator

Failed to deploy to Graph node https://api.thegraph.com/deploy/: subgraph failure::[Base Mainnet] chain is no longer supported on the hosted service. Please deploy to the decentralized network.

@melotik @bye43

@bye43 bye43 moved this from Deploy To Hosted Service to Deploy To Decentralized Network in Subgraph Development Nov 29, 2023
@melotik melotik moved this from Deploy To Decentralized Network to Done in Subgraph Development Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new subgraph p1 medium priority
Projects
Development

Successfully merging a pull request may close this issue.

3 participants