Custom Cassandra YAML and JVM options. #9
Conversation
There was a problem hiding this comment.
Very nice @phrynchanka ! Only one minor nit but can we also add a test? Want to make sure this feature continues to works as we make future updates.
@samvantran @mpereira |
Configurable CASSANDRA_YAML_OVERRIDES
phrynchanka
force-pushed
the
DCOS-59495
branch
from
dffdd03 to
58ccf74
Compare
There was a problem hiding this comment.
Thanks @phrynchanka, this looks great!
I have left some requests, but none of them are blocking.
Do you intend on adding a test for JVM options as well?
Co-Authored-By: Murilo Pereira <[email protected]>
Co-Authored-By: Murilo Pereira <[email protected]>
Co-Authored-By: Murilo Pereira <[email protected]>
|
Thanks @mpereira !
Yep. Now working on it. |
Co-Authored-By: Murilo Pereira <[email protected]>
|
Test for jvm options done. |
| "github.com/mesosphere/kudo-cassandra-operator/tests/utils/cassandra" | ||
| "github.com/mesosphere/kudo-cassandra-operator/tests/utils/k8s" | ||
| "github.com/mesosphere/kudo-cassandra-operator/tests/utils/kubectl" | ||
| "github.com/mesosphere/kudo-cassandra-operator/tests/utils/kudo" |
There was a problem hiding this comment.
I'm curious about this change.
| return getConfigurationFromNodeLogs(namespaceName, instanceName, "o.a.c.service.CassandraDaemon - JVM Arguments: \\[(.+)\\]", ",") | ||
| } | ||
|
|
||
| func getConfigurationFromNodeLogs( |
There was a problem hiding this comment.
Thanks for the great work @phrynchanka.
I've opened a PR on top of this PR with a few formatting and naming changes. Nothing blocking, but please take a look: #20
mpereira
changed the title
* Move cassandra.yaml related parameter to its block. * Improve test name. * Fix custom JVM options test name. * Improve function name. * Enforce 80 lines and consistency with line breaks. * The KUDO dependency updated, reflect that.
What changes are proposed in this PR?
Resolves DCOS-59496
Resolves DCOS-59495
This PR Implement adding:
Implementation steps :
CUSTOM_CASSANDRA_YAML_BASE64andCUSTOM_JVM_OPTIONS_BASE64properties toparams.ymljvm-options.yamlandcassandra-yaml.yaml.How were these changes tested?
Manually tested
cassandra-node-0from k8s ui. Onexecconsolecatthe content ofetc/cassadra/cassanda.yamlandetc/cassadra/jvm.optionsand see that properties were decoded and propagated.