Skip to content
This repository has been archived by the owner on Oct 23, 2024. It is now read-only.

Introduce a parameter to set annotations for the external service #164

Merged
merged 4 commits into from
Nov 4, 2020

Conversation

nfnt
Copy link
Contributor

@nfnt nfnt commented Oct 30, 2020

ExternalDNS access is enabled by adding external-dns.alpha.kubernetes.io/* annotations to services. This can be done using the EXTERNAL_SERVICE_ANNOTATIONS parameter.

ExternalDNS access is enabled by adding "external-dns.alpha.kubernetes.io/*" annotations to services. This can be done using the "EXTERNAL_SERVICE_ANNOTATIONS" parameter.
@nfnt nfnt requested a review from ANeumann82 as a code owner October 30, 2020 10:31
@nfnt nfnt self-assigned this Oct 30, 2020
@meichstedt
Copy link
Contributor

Can you add docs similar to these so we have some examples of what the config looks like?

Copy link
Contributor

@ANeumann82 ANeumann82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, the hint could be improved though.

templates/operator/params.yaml.template Outdated Show resolved Hide resolved
Jan Schlicht and others added 2 commits November 4, 2020 09:29
@nfnt nfnt merged commit 8641668 into master Nov 4, 2020
@nfnt nfnt deleted the nfnt/external-service-annotations branch November 4, 2020 10:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants