This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
Update Medusa to 0.6.0 #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andreas Neumann <[email protected]>
Signed-off-by: Andreas Neumann <[email protected]>
Don't include own node in seed list Adjust deployment of resources so that the dependency hash change is not triggered Signed-off-by: Andreas Neumann <[email protected]>
Signed-off-by: Andreas Neumann <[email protected]>
Signed-off-by: Andreas Neumann <[email protected]>
Signed-off-by: Andreas Neumann <[email protected]>
Signed-off-by: Andreas Neumann <[email protected]>
porridge
suggested changes
Jun 1, 2020
| @@ -45,8 +45,8 @@ data: | |||
|
|
|||
| HOSTNAME=${POD_NAME}.{{ .Name }}-svc.{{ .Namespace }}.svc.cluster.local | |||
|
|
|||
| # On Cluster creation or when adding a node, every node except the very first one shouldn't be a seed node on startup | |||
| if [ "${POD_NAME}" != "${NODE_ZERO}" ] && [ ! -d /var/lib/cassandra/data ]; then | |||
| # Every node except the very first one shouldn't see themself as a seed node on startup | |||
There was a problem hiding this comment.
Suggested change
| # Every node except the very first one shouldn't see themself as a seed node on startup | |
| # Every node except the very first one shouldn't see themseves as a seed node on startup |
Signed-off-by: Andreas Neumann <[email protected]>
Signed-off-by: Andreas Neumann <[email protected]>
Signed-off-by: Andreas Neumann <[email protected]>
porridge
approved these changes
Jun 2, 2020
| @@ -11,7 +11,9 @@ source "${project_directory}/metadata.sh" | |||
|
|
|||
| if [[ -n ${IMAGE_DISAMBIGUATION_SUFFIX:-} ]]; then | |||
| # Refresh templated files to pick up the suffix, if explicitly set. | |||
| "${project_directory}/tools/docker.sh" "${project_directory}/tools/compile_templates.sh" | |||
| "${project_directory}/tools/docker.sh" \ | |||
There was a problem hiding this comment.
🤦♂️
Found like you said we would 😆
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to enable backup/restore for encrypted clusters
Signed-off-by: Andreas Neumann [email protected]