Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of ENV vars in configuration parameters #107

Open
philwinder opened this issue Feb 1, 2016 · 1 comment
Open

Allow use of ENV vars in configuration parameters #107

philwinder opened this issue Feb 1, 2016 · 1 comment

Comments

@philwinder
Copy link
Collaborator

Automatically expand any CLI/Env var config options if they contain env vars. For example, many installations don't install the mesos sandbox and /tmp/mesos. They use /var/lib/mesos. So to make the default logstash example more universal this should be allowed:

    "EXECUTOR_FILE_PATH": "$MESOS_WORK_DIR/slaves/*/frameworks/*/executors/*/runs/*/stdout, $MESOS_WORK_DIR/slaves/*/frameworks/*/executors/*/runs/*/stderr, $MESOS_LOG_DIR/*.INFO, $MESOS_LOG_DIR/*.WARNING"

Note the use of valid Mesos Env vars to define the work directory and the log directory. But this doesn't work. It passes the $VAR straight through to logstash.

@jhftrifork
Copy link

This is one case where it would be more natural to use an actual Logstash config file instead of CLI params or environment variables. The config file could have a $MESOS_WORK_DIR free variable. See #109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants