Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify diego-release to use modified auctioneer #2

Open
ilackarms opened this issue Nov 25, 2015 · 2 comments
Open

Modify diego-release to use modified auctioneer #2

ilackarms opened this issue Nov 25, 2015 · 2 comments

Comments

@ilackarms
Copy link
Member

Rather than manually replacing the auctioneer binary (noted here: https://github.com/mesos/cloudfoundry-mesos/blob/master/docs/getting-started.md), I would recommend forking and modifying the Diego BOSH release to deploy the modified auctioneer itself.
-You will need to modify the job template for the auctioneer https://github.com/cloudfoundry-incubator/diego-release/blob/develop/jobs/auctioneer/templates/auctioneer_ctl.erb
-The only other step you should need would be to replace the auctioneer submodule in the diego-release with your auctioneer (it would make sense to fork the CF auctioneer and put your changes in there to streamline this process).

@jianhuiz
Copy link
Member

What we are considering is to create a separate release instead of modifying diego-release, and deploy this auctioneer job from that release. This is however not our priority right now, we welcome any pull request.

@Amit-PivotalLabs
Copy link

I agree with @jianhuiz, having a separate release for the auctioneer probably makes more sense. If you fork the whole diego-release then you have to continually work to keep your fork up-to-date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants