openssl wrap doesn't build on windows (vs via ninja)

[anarazel]

Hi,

PS C:\Users\anfreund\src\pg-meson\build-ninja-x64> ninja .\subprojects\openssl-1.1.1l\openssl.exe
[1/1] Linking target subprojects/openssl-1.1.1l/openssl.exe
FAILED: subprojects/openssl-1.1.1l/openssl.exe subprojects/openssl-1.1.1l/openssl.pdb
"link" @subprojects/openssl-1.1.1l/openssl.exe.rsp
LINK : fatal error LNK1181: cannot open input file 'subprojects\openssl-1.1.1l\crypto.lib'

As far as I can tell the reason for the failure to build is that the buildsystem contained in the wrap doesn't take care of exporting symbols. Due to that link.exe doesn't produce an import library, which then causes this issue.

CC: @nazar-pc

Regards,

Andres

[xclaesse]

The good news is we now have Windows CI, so if someone does an update of openssl wrap it will be tested this time.

[nazar-pc]

Is it MSVC's linker? I'm running Windows builds on CI without problems, but I had to make GNU linker unavailable for MSVC builds or else it didn't work together

[anarazel]

On 2021-10-06 08:52:12 -0700, Nazar Mokrynskyi wrote: Is it MSVC's linker? I'm running Windows builds on CI without problems, but I had to make GNU linked unavailable for MSVC builds.

yes, it was MSVC's linker.

[xclaesse]

I can confirm, the issue is the generator script configure openssl with no-shared so libcrypto.def is not generated. We also have to pass that file to library(). While looking into this, I noticed there is also a ld script for the linux ABI.

[vinipsmaker]

Any updates on this?

[punytroll]

Good to know, that I'm not the only one with this problem!

@xclaesse You mentioned some things in your reply from nearly a year ago. Could you elaborate on the issues ... I am very willing to try my hands on this, but I could use some starters ...

Thanks! :)

[amyspark]

I have a version ready for public consumption, I'll update it to 1.1.1q and fix #428 before linking it here.

[amyspark]

@punytroll @jfinkhaeuser, I've made a custom wrap for OpenSSL 1.x based on the existing version for v3.

Mine improves the following bits:

• support for MSYS compilers (64 and 32-bit) as well as MSVC
• detection of the assemblers available (gas/nasm)
• adds a .pc file for easy lookup
• enabled the usage of nasm for MSVC

The latter was a longstanding TODO since 7dfccc1.

You'll find the wrap in this branch and the release here. I'm not sure if/how I could upstream it here, given that wrapdb has already moved to the 3.x branch.

[jfinkhaeuser]

Thank you, I'll check it out!

[jfinkhaeuser]

@amyspark it doesn't quite work for me, but it's enough that I can probably work my way there. FWIW, I would have no problem with using v3, but then there's #428 and #427 in those.

At any rate, I have more info with this, so thank you very much!

[lemosjose]

Any udpates on that? got into similar stuff while building a project, and i see it's not closed yet

[hrxi]

Would be fixed by #1283.