Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix llvm-rc Matching Error #13450

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CaptainNeil
Copy link

Fix llvm-rc Matching Error

Clang Version:16.0.5

The command line output of llvm-rc /? is:

>llvm-rc /?
OVERVIEW: Resource Converter

USAGE: rc [options] file...

OPTIONS:
  /?             Display this help and exit.
  /C <value>     Set the codepage used for input strings.
  /dry-run       Don't compile the input; only try to parse it.
  /D <value>     Define a symbol for the C preprocessor.
  /FO <value>    Change the output file location.
  /H             Display this help and exit.
  /I <value>     Add an include path.
  /LN <value>    Set the default language name.
  /L <value>     Set the default language identifier.
  /no-preprocess Don't try to preprocess the input file.
  /N             Null-terminate all strings in the string table.
  /U <value>     Undefine a symbol for the C preprocessor.
  /V             Be verbose.
  /X             Ignore 'include' variable.
  /Y             Suppress warnings on duplicate resource IDs.

Additionally, this issue also leads to: 4105

Fix llvm-rc Matching Error
@CaptainNeil CaptainNeil changed the title Update windows.py Fix llvm-rc Matching Error Jul 19, 2024
Copy link
Member

@eli-schwartz eli-schwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note also: commit message should describe the change, github's automatically generated web editor commit message "Update windows.py" lacks that detail.

@@ -87,7 +87,7 @@ def _find_resource_compiler(self, state: 'ModuleState') -> T.Tuple[ExternalProgr

for (arg, match, rc_type) in [
('/?', '^.*Microsoft.*Resource Compiler.*$', ResourceCompilerType.rc),
('/?', 'LLVM Resource Converter.*$', ResourceCompilerType.rc),
('/?', '^.*LLVM Resource Converter.*$', ResourceCompilerType.rc),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the string we are trying to match is:

OVERVIEW: Resource Converter

How does this change help?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what you mean by that reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants