Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn (or error?) on unhandled options passed to meson install #670

Open
WillAyd opened this issue Sep 24, 2024 · 2 comments
Open

Warn (or error?) on unhandled options passed to meson install #670

WillAyd opened this issue Sep 24, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@WillAyd
Copy link

WillAyd commented Sep 24, 2024

It appears that having:

[tool.meson-python.args]
install = ['--skip-subprojects nanoarrow']

is a no-op. To actually skip the subproject, I have to use:

[tool.meson-python.args]
install = ['--skip-subprojects=nanoarrow']

Is this distinction intentional?

@dnicolodi
Copy link
Member

The correct form is either install = ['--skip-subprojects', 'nanoarrow'] or install = ['--skip-subprojects=nanoarrow']. The install = ['--skip-subprojects nanoarrow'] form passes a single --skip-subprojects nanoarrow flag, which is incorrect. I don't know why this does not result in an error though.

@dnicolodi dnicolodi changed the title skip-subprojects requires equal sign to parse correctly Warn (or error?) on unhaldled options passed to meson install Oct 10, 2024
@dnicolodi
Copy link
Member

meson-python allows to specify options to be passed to the different meson subcommands invoked during the build: meson setup, meson compile, meson install. However, it does not really execute meson install but performs equivalent operations. For this reason, the options that would be passed to meson install are interpreted directly by meson-python. meson-python supports the --tags and --skip-subprojects options and ignores everything else. As reported by the OP, this may cause confusion when options are misspelled or when unsupported options are specified.

Emitting an error when an unsupported option is specified may be the best thing to do. A warning should be emitted, at least.

@dnicolodi dnicolodi added the enhancement New feature or request label Oct 10, 2024
@rgommers rgommers changed the title Warn (or error?) on unhaldled options passed to meson install Warn (or error?) on unhandled options passed to meson install Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants