Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Hide the Private Key by default #1414

Open
1 task done
Dokument opened this issue Nov 16, 2024 · 2 comments
Open
1 task done

[Feature Request]: Hide the Private Key by default #1414

Dokument opened this issue Nov 16, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@Dokument
Copy link

Contact Details

[email protected]

Tell us your idea.

I would like for the app to hide the node private key by default. Today there is no way to safely share your public key unless you have already copied it from the application in private. Opening the security page reveals your private key in plaintext which would make it trivial for anyone to make a copy by taking a picture or reviewing security camera footage (etc).

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Dokument Dokument added the enhancement New feature or request label Nov 16, 2024
@Kealper
Copy link

Kealper commented Nov 20, 2024

I think this could be a good change, to make the private key textbox act like a password box instead of a regular textbox, that way it would have the contents hidden by default but a button on the textbox could be clicked to toggle showing the private key or not.

The web client already does it this way, although I don't know if the iOS client does or not as I don't have any iOS devices to test, so there's at least some precedent for it that I know of.

I don't know that I would ever share my public key by showing someone that page but it seems like it's good practice to hide the private key by default because like you said, if you did happen to open it and there was footage with enough resolution that could see your screen, there's a chance a malicious person could pull the private key from the recording.

@Dokument
Copy link
Author

I don't know that I would ever share my public key by showing someone that page

I am unaware of any other way to access the public key while in the field, excluding via the web interface such as you mentioned.

An alternate solution could be an option to view the public key for any node from the nodes list, including your own node. I still want to keep this feature request open since hiding the private key by default really does help security by a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants