Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a helper Field class #181

Open
ddundo opened this issue Apr 25, 2024 · 1 comment
Open

Introduce a helper Field class #181

ddundo opened this issue Apr 25, 2024 · 1 comment
Labels
clarity Something isn't sufficiently clear
Milestone
Version 1

Comments

@ddundo
Copy link
Member

ddundo commented Apr 25, 2024 •
edited
Loading

Currently information about each field is scattered around in different dictionaries of MeshSeq and TimePartition: fields, _fs, field_types, etc. I think we should introduce a class Field that would hold all of these at the same place.

So e.g. u = Field(name="velocity", type="unsteady") etc.
@ddundo ddundo added the clarity Something isn't sufficiently clear label Apr 25, 2024
@ddundo ddundo added this to the Version 1 milestone Apr 25, 2024
@jwallwork23
Copy link
Member

Sounds good, thanks. Note that I think fields were originally associated with TimePartition in case we wanted to support having different timesteps for different fields.

@ddundo ddundo mentioned this issue Jun 20, 2024
Merged
@ddundo ddundo removed their assignment Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clarity Something isn't sufficiently clear
Projects
Mesh Adaptation development board
Status: Backlog
Milestone
Version 1
Development

No branches or pull requests
2 participants
@jwallwork23 @ddundo