Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate qoi_kwargs out of solver_kwargs #126

Open
jwallwork23 opened this issue Mar 4, 2024 · 0 comments
Open

Separate qoi_kwargs out of solver_kwargs #126

jwallwork23 opened this issue Mar 4, 2024 · 0 comments
Labels
good first issue Good for newcomers refactor A suggested reworking of the code
Milestone

Comments

@jwallwork23
Copy link
Member

Currently AdjointMeshSeq.solve_adjoint passes options to the QoI via the solver options. It would make more sense to just pass them separately.

@jwallwork23 jwallwork23 added the refactor A suggested reworking of the code label Mar 4, 2024
@jwallwork23 jwallwork23 added this to the Version 1 milestone Mar 4, 2024
@jwallwork23 jwallwork23 added the good first issue Good for newcomers label Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers refactor A suggested reworking of the code
Projects
Development

No branches or pull requests

1 participant