Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyError in indicate_errors for steady fields in combined steady-unsteady fields #119

Closed
ddundo opened this issue Mar 4, 2024 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@ddundo
Copy link
Member

ddundo commented Mar 4, 2024

Since #114 and different solution dictionary structures for steady and unsteady fields, L160 and L162 in indicate_errors raise a KeyError. It happens when we have a combination of steady and unsteady fields, so they raise a KeyError for the "steady" fields which do not have the FWD_OLD key in their solutions dictionary.

I guess I'm the only one with this problem at the moment so I fixed it locally and we can address it properly in the future alongside #55

@ddundo ddundo changed the title Error in indicate_errors for unsteady fields in combined steady-unsteady fields Error in indicate_errors for steady fields in combined steady-unsteady fields Mar 4, 2024
@ddundo ddundo changed the title Error in indicate_errors for steady fields in combined steady-unsteady fields KeyError in indicate_errors for steady fields in combined steady-unsteady fields Mar 4, 2024
@ddundo ddundo added the bug Something isn't working label Mar 4, 2024
@ddundo ddundo added this to the Version 1 milestone Mar 4, 2024
@jwallwork23
Copy link
Member

Thanks for reporting this @ddundo. I do intend to get back to finishing your multiple variables issue but there have been various other changes blocking progress along the way. Currently, I'm waiting for #113 to go through. (Feel free to pick it up for review if you like.)

@ddundo ddundo self-assigned this Apr 17, 2024
@ddundo
Copy link
Member Author

ddundo commented Apr 30, 2024

This is actually not relevant since lagged fields will be extracted (see #153), so I'll close

@ddundo ddundo closed this as completed Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants