Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow underscores in application names #313

Merged
merged 2 commits into from
Apr 14, 2022
Merged

Allow underscores in application names #313

merged 2 commits into from
Apr 14, 2022

Conversation

janelletavares
Copy link
Contributor

@janelletavares janelletavares commented Apr 13, 2022

Description of change

Fixes https://github.com/meroxa/platform-api/issues/1021

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Unit Tests
  • Tested in staging
  • Tested in minikube

Demo

Screenshot from 2022-04-12 17-46-40

Additional references

Documentation updated

@janelletavares janelletavares requested review from a team, simonl2002, ericcheatham, raulb and hariso and removed request for a team, simonl2002 and ericcheatham April 13, 2022 00:45
@janelletavares janelletavares merged commit 8cb828f into master Apr 14, 2022
@janelletavares janelletavares deleted the underscores branch April 14, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants