Meroxa builds describe #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janelletavares
force-pushed
the
meroxa-builds-describe
branch
from
eb57603 to
ebd2d93
Compare
added 3 commits
April 4, 2022 12:17
janelletavares
approved these changes
Apr 4, 2022
raulb
reviewed
Apr 5, 2022
| } | ||
|
|
||
| func (*Builds) FeatureFlag() (string, error) { | ||
| return "turbine", fmt.Errorf("no access to the Meroxa Data Processes feature") |
There was a problem hiding this comment.
@ericcheatham I think Processes was a typo here, right? (it should be Meroxa Data Applications)
raulb
reviewed
Apr 5, 2022
|
|
||
| func (o *Builds) Docs() builder.Docs { | ||
| return builder.Docs{ | ||
| Short: "Manage Process builds on Meroxa", |
There was a problem hiding this comment.
Same here (it should be something like Operate with Application builds on Meroxa)`
There was a problem hiding this comment.
Nvm, @janelletavares corrected me that this should be for Processes specifically. Ignore my comment.
raulb
reviewed
Aug 2, 2022
| @@ -960,6 +965,70 @@ func extendedFunctionsTable(functions []*meroxa.Function) string { | |||
| return subTable | |||
| } | |||
|
|
|||
| // BuildsTable displays multiple build records for future listing per app. | |||
| func BuildsTable(builds []*meroxa.Build, hideHeaders bool) string { | |||
There was a problem hiding this comment.
I just noticed this is not being used anywhere. Will remove in #386 as part of a refactor I'm doing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Fixes https://github.com/meroxa/turbine-project/issues/84
Type of change
How was this tested?
Demo