Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to init and run #293

Merged
merged 5 commits into from
Mar 31, 2022
Merged

Tweaks to init and run #293

merged 5 commits into from
Mar 31, 2022

Conversation

janelletavares
Copy link
Contributor

@janelletavares janelletavares commented Mar 29, 2022

Description of change

because of the naming clash between turbine-js and turbine-py, initiatializing a py app made a js app. also, error handling still wasn't quite right and calling run helps confirm all the right things are happening during init.

Fixes https://github.com/meroxa/turbine-project/issues/124

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Unit Tests
  • Tested in staging
  • local manual

Demo

before after

Additional references

Documentation updated

@janelletavares janelletavares marked this pull request as draft March 29, 2022 23:48
@janelletavares janelletavares requested review from a team, samirketema and lyuboxa and removed request for a team March 30, 2022 23:35
@janelletavares janelletavares marked this pull request as ready for review March 30, 2022 23:35
@janelletavares janelletavares changed the title Tweaks to calling turbine-py Tweaks to init and run Mar 30, 2022
@janelletavares
Copy link
Contributor Author

this is a bunch of random stuff.... it is what it is

@janelletavares janelletavares merged commit 58ed05b into master Mar 31, 2022
@janelletavares janelletavares deleted the py-pkg branch March 31, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants