Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No longer expose or display IDs #282

Merged
merged 3 commits into from
Mar 25, 2022
Merged

No longer expose or display IDs #282

merged 3 commits into from
Mar 25, 2022

Conversation

janelletavares
Copy link
Contributor

@janelletavares janelletavares commented Mar 17, 2022 •
edited
Loading

Description of change

Fixes https://github.com/meroxa/product/issues/225
depends on https://github.com/meroxa/meroxa-go/pull/105

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Unit Tests
  • Tested in staging

Demo

before after

Additional references

Documentation updated

@janelletavares janelletavares requested review from a team, hariso and samirketema and removed request for a team March 17, 2022 22:26
@janelletavares
Copy link
Contributor Author

I missed this bit in API (https://github.com/meroxa/platform-api/pull/982/files) which is causing the acceptance tests to fail. I tested it in minikube.

raulb
raulb approved these changes Mar 25, 2022
View reviewed changes
Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. Good to go once we use upstream meroxa-go.

@janelletavares janelletavares merged commit db7fb1a into master Mar 25, 2022
@janelletavares janelletavares deleted the no-ids branch March 25, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulb raulb raulb approved these changes

@hariso hariso Awaiting requested review from hariso hariso was automatically assigned from meroxa/platform-backend

@samirketema samirketema Awaiting requested review from samirketema samirketema was automatically assigned from meroxa/platform-backend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janelletavares @raulb