Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(apps): use absolute path for run command #269

Merged
merged 2 commits into from
Mar 7, 2022
Merged

bug(apps): use absolute path for run command #269

merged 2 commits into from
Mar 7, 2022

Conversation

janelletavares
Copy link
Contributor

@janelletavares janelletavares commented Mar 4, 2022 •
edited
Loading

Description of change

Fixes https://github.com/meroxa/turbine-project/issues/68

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Unit Tests
  • manually testing locally
  • Tested in staging

Demo

Screenshot from 2022-03-04 13-10-40

Screenshot from 2022-03-04 13-09-10

Additional references

Documentation updated

@janelletavares janelletavares requested review from a team, simonl2002 and ericcheatham and removed request for a team March 4, 2022 21:33
ahmeroxa
ahmeroxa approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@ahmeroxa ahmeroxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@janelletavares janelletavares merged commit 661f382 into master Mar 7, 2022
@janelletavares janelletavares deleted the run-path branch March 7, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmeroxa ahmeroxa ahmeroxa approved these changes

@simonl2002 simonl2002 Awaiting requested review from simonl2002 simonl2002 was automatically assigned from meroxa/platform-backend

@ericcheatham ericcheatham Awaiting requested review from ericcheatham ericcheatham was automatically assigned from meroxa/platform-backend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janelletavares @ahmeroxa