Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apps): Absorb turbine changes to create a .gitignore when doing git initialize #268

Merged
merged 4 commits into from
Mar 8, 2022

Conversation

janelletavares
Copy link
Contributor

@janelletavares janelletavares commented Mar 4, 2022

…alize

Description of change

Fixes https://github.com/meroxa/turbine-project/issues/76

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Unit Tests
  • Local manual test
  • Tested in staging

Demo

Screenshot from 2022-03-04 11-20-23

Additional references

Documentation updated

@janelletavares janelletavares force-pushed the apps-gitignore branch 3 times, most recently from ff35b4c to dd3be70 Compare March 4, 2022 20:04
@janelletavares janelletavares requested review from a team, ericcheatham and hariso and removed request for a team March 4, 2022 21:33
Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janelletavares I think this should be part of every turbine-lang where we currently have a folder to populate when doing git init. I'll work on what could be look like for go, and we could chat later about to see what you think.

cmd/meroxa/root/apps/init.go Outdated Show resolved Hide resolved
cmd/meroxa/root/apps/init_test.go Outdated Show resolved Hide resolved
@janelletavares janelletavares changed the title feat(apps): Create a .gitignore and first commit when doing git initi… feat(apps): Absorb turbine changes to create a .gitignore when doing git initialize Mar 7, 2022
@janelletavares janelletavares merged commit 23b3302 into master Mar 8, 2022
@janelletavares janelletavares deleted the apps-gitignore branch March 8, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants