feat(apps): Apps create command with feature flag #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janelletavares
requested review from
a team,
lyuboxa and
anna-cross
and removed request for
a team
janelletavares
force-pushed
the
applications-create
branch
from
005bebe to
d6082c1
Compare
raulb
requested changes
Mar 1, 2022
raulb
approved these changes
Mar 1, 2022
janelletavares
commented
Mar 1, 2022
| return nil | ||
| } | ||
|
|
||
| func (c *Create) getLang() (string, error) { | ||
| if path := c.flags.Path; path != "" { |
There was a problem hiding this comment.
what if path is pwd... we still need that to be specified as a flag?
what if the supplied language is different from the app.json language?
There was a problem hiding this comment.
what if path is pwd... we still need that to be specified as a flag?
@janelletavares That's a great question. I'm making specifying the path mandatory (notice I'm not reading from pwd) but maybe we could make that change.
what if the supplied language is different from the app.json language?
Language specified in the app.json currently takes precedence (i.e. if both provided we ignore the currently ignore --lang)
added 2 commits
March 1, 2022 14:40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
meroxa apps create NAME
Fixes https://github.com/meroxa/turbine-project/issues/42
Type of change
How was this tested?
Demo
Additional references
Documentation updated