Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename environment offerings #233

Merged
merged 1 commit into from
Jan 4, 2022
Merged

Rename environment offerings #233

merged 1 commit into from
Jan 4, 2022

Conversation

dianadoherty
Copy link
Contributor

@dianadoherty dianadoherty commented Jan 3, 2022

Description of change

We want to rename environment offerings to the following:
Dedicated -> Private
Hosted -> Self-hosted

Fixes #232
Depends on: https://github.com/meroxa/meroxa-go/pull/88

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Unit Tests
  • Tested in staging

Demo

Before this pull-request

meroxa env create --help
Create an environment

Usage:
  meroxa environments create NAME [flags]

Examples:

meroxa env create my-env \
	--type hosted \ 
	--provider aws \ 
	--region us-east-1 \ 
	--config '{\"aws_access_key_id\":\"my_access_key\", \"aws_secret_access_key\":\"my_secret_access_key\"}'
meroxa env create       
Environment name (optional): 
Type (hosted or dedicated): hosted
Cloud provider: aws
Region: us-east-1
✗ Does your environment require configuration: 
Environment details:
	Type: hosted
	Provider: aws
	Region: us-east-1

After this pull-request

meroxa env create --help
Create an environment

Usage:
  meroxa environments create NAME [flags]

Examples:

meroxa env create my-env --type self_hosted --provider aws --region us-east-1 --config "{\"aws_access_key_id\":\"my_access_key\", \"aws_secret_access_key\":\"my_secret_access_key\"}"

meroxa env create
Environment name (optional): 
Type (self_hosted or private): self_hosted
Cloud provider: aws
Region: us-east-1
✔ Region: us-east-1█
Environment details:
	Type: self_hosted
	Provider: aws
	Region: us-east-1

Additional references

Any additional links (if appropriate)

Documentation updated

Make sure that our documentation is accordingly updated when necessary.

You can do that by opening a pull-request to our (🔒 private, for now) repository: https://github.com/meroxa/meroxa-docs.

✨ In the future, there will be a GitHub action taking care of these updates automatically. ✨

Provide PR link:

@dianadoherty dianadoherty requested review from a team, hariso and ahmeroxa and removed request for a team, hariso and ahmeroxa January 3, 2022 17:37
@dianadoherty dianadoherty merged commit 90cb9f6 into master Jan 4, 2022
@dianadoherty dianadoherty deleted the rename-env-offerings branch January 4, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Stage 2: CLI] Rename environment offerings
2 participants