Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show common environment when no environment provided #231

Merged
merged 3 commits into from
Jan 19, 2022

Conversation

janelletavares
Copy link
Contributor

@janelletavares janelletavares commented Dec 20, 2021

Description of change

A brief description of the change, what it is and why it was made.

Fixes #229
Fixes #230

Type of change

  • New feature
  • [X ] Bug fix
  • Refactor
  • Documentation

How was this tested?

  • [ X] Unit Tests
  • Tested in staging

Demo

Before this pull-request

$ m pipeline describe jtnewname
UUID: 9b16822d-a546-4cf8-be6b-300471f6dab2
ID: 2961
Name: jtnewname
State: Healthy

$ m connector describe mongodb-connector
UUID: a69160c7-0014-40e7-a953-fe5042876ebe
ID: 5532
Name: mongodb-connector
Type: debezium-mongo-source
Streams: (output) resource-6633-459461.meroxa.meroxa
State: pending
Pipeline: jtest
Environment: janelle-dec9

After this pull-request

$ m pipeline describe jtnewname
UUID: 9b16822d-a546-4cf8-be6b-300471f6dab2
ID: 2961
Name: jtnewname
Environment Name: common
State: Healthy

$ m connector describe mongodb-connector
UUID: 91ee0a06-436f-4c7f-a459-0a920c623ed0
ID: 5533
Name: mongodb-connector
Type: debezium-mongo-source
Streams: (output) resource-6633-666758.meroxa.meroxa
State: running
Pipeline: jtest
Environment UUID: 514280e6-6825-4728-b98a-cc4a24cb38aa
Environment Name: janelle-dec9

Additional references

Any additional links (if appropriate)

Documentation updated

Make sure that our documentation is accordingly updated when necessary.

You can do that by opening a pull-request to our (🔒 private, for now) repository: https://github.com/meroxa/meroxa-docs.

✨ In the future, there will be a GitHub action taking care of these updates automatically. ✨

Provide PR link:

@janelletavares janelletavares marked this pull request as draft December 20, 2021 05:48
@janelletavares janelletavares marked this pull request as ready for review December 21, 2021 04:00
@janelletavares janelletavares requested review from a team, ahmeroxa and anna-cross and removed request for a team December 21, 2021 15:58
@raulb
Copy link
Member

raulb commented Dec 21, 2021

@janelletavares this was by design. Only when listing environments, we're showing "common" if no environments is not set. For specific environments, we mentioned we wouldn't show environments unless is present. Maybe we changed that decision?

@janelletavares
Copy link
Contributor Author

@janelletavares this was by design. Only when listing environments, we're showing "common" if no environments is not set. For specific environments, we mentioned we wouldn't show environments unless is present. Maybe we changed that decision?

Ah, I was not aware of that. It came up in standup that more consistency would be better. Maybe just the changes for issue #229 and not for #230 then.

@raulb
Copy link
Member

raulb commented Dec 23, 2021

Ah, I was not aware of that. It came up in standup that more consistency would be better. Maybe just the changes for issue #229 and not for #230 then.

@janelletavares If that's the case, go for it! It sounds like your information is more up to date.

Copy link
Contributor

@anna-cross anna-cross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes approved! Tested them locally via CLI , and got the same results ! :)

@janelletavares janelletavares merged commit b871b18 into master Jan 19, 2022
@janelletavares janelletavares deleted the env-table-display branch January 19, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants