Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment create example doesn't work copy-paste'd #225

Merged
merged 2 commits into from
Dec 9, 2021
Merged

Conversation

janelletavares
Copy link
Contributor

@janelletavares janelletavares commented Dec 8, 2021

Description of change

In the env create example, the --config string doesn't marshal to a map and the \ for newline get translated to returns

Fixes error creating an environment using example in docs.

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Unit Tests
  • Tested in staging

Demo

Before this pull-request

Usage:
  meroxa environments create NAME [flags]

Examples:

meroxa env create my-env \
	--type hosted \ 
	--provider aws \ 
	--region us-east-1 \ 
	--config '{\"aws_access_key_id\":\"my_access_key\", \"aws_secret_access_key\":\"my_secret_access_key\"}'

Flags:
  -c, --config string     environment configuration based on type and provider (e.g.: --config '{"aws_access_key_id":"my_access_key", "aws_secret_access_key":"my_secret_access_key"}')

After this pull-request

Usage:
  meroxa environments create NAME [flags]

Examples:

meroxa env create my-env --type hosted --provider aws --region us-east-1 --config "{\"aws_access_key_id\":\"my_access_key\", \"aws_secret_access_key\":\"my_secret_access_key\"}"

Flags:
  -c, --config string     environment configuration based on type and provider (e.g.: --config "{"aws_access_key_id":"my_access_key", "aws_secret_access_key":"my_secret_access_key"}")

@janelletavares janelletavares requested review from a team, simonl2002 and raulb and removed request for a team December 8, 2021 20:01
@raulb raulb merged commit 4247739 into master Dec 9, 2021
@raulb raulb deleted the env-example branch December 9, 2021 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants