Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connectors): Add environments #221

Merged
merged 8 commits into from
Dec 1, 2021

Conversation

janelletavares
Copy link
Contributor

@janelletavares janelletavares commented Nov 24, 2021

Description of change

A brief description of the change, what it is and why it was made.

Fixes #215
Fixes #216

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Unit Tests
  • Tested in staging

Demo

Before this pull-request

❯ meroxa connectors ls
  ID               NAME                  TYPE                        STREAMS                      STATE    PIPELINE 
====== ============================= ============= ============================================ ========= ==========
 2479   resource-942792-2630-203946   jdbc-source   (output) resource-2630-240664-public.Users   running   default  

❯ meroxa connectors describe resource-942792-2630-203946                          
       ID:   2479                                       
     Name:   resource-942792-2630-203946                
     Type:   jdbc-source                                
  Streams:   (output) resource-2630-240664-public.Users 
    State:   running                                    
 Pipeline:   default    

After this pull-request

❯ meroxa connectors ls                                  
                 UUID                    ID               NAME                  TYPE                        STREAMS                      STATE    PIPELINE   ENVIRONMENT 
====================================== ====== ============================= ============= ============================================ ========= ========== =============
 24ac3762-3a56-4fc3-8bd4-29647faffe21   2479   resource-942792-2630-203946   jdbc-source   (output) resource-2630-240664-public.Users   running   default    common      

❯ meroxa connectors describe resource-942792-2630-203946
        UUID:   24ac3762-3a56-4fc3-8bd4-29647faffe21       
          ID:   2479                                       
        Name:   resource-942792-2630-203946                
        Type:   jdbc-source                                
     Streams:   (output) resource-2630-240664-public.Users 
       State:   running                                    
    Pipeline:   default                                    
 Environment:   common 

@janelletavares janelletavares force-pushed the janelle_describe_connector_with_environments branch from 45b66d0 to b151274 Compare November 24, 2021 01:18
utils/display.go Outdated Show resolved Hide resolved
@janelletavares janelletavares force-pushed the janelle_describe_connector_with_environments branch from 2185540 to 496acbf Compare November 29, 2021 23:35
Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janelletavares LGTM. Do you mind including an output demo in the pull-request description of how it looks before and after this change? This is useful to illustrate these changes that end up being referenced from the changelog.

Thank you.

@janelletavares
Copy link
Contributor Author

@janelletavares LGTM. Do you mind including an output demo in the pull-request description of how it looks before and after this change? This is useful to illustrate these changes that end up being referenced from the changelog.

Thank you.

I'm having trouble with login. I'll reach out for help tomorrow.

@raulb
Copy link
Member

raulb commented Dec 1, 2021

@raulb raulb merged commit 074fe3e into master Dec 1, 2021
@raulb raulb deleted the janelle_describe_connector_with_environments branch December 1, 2021 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants