absorb new meroxa-go interface; small doc changes #217
Conversation
janelletavares
requested review from
a team,
owenthereal and
simonl2002
and removed request for
a team
|
@janelletavares started reviewing this pull-request, but I think it lacks some context on the motivation behind it. Maybe adding a link to the change made in meroxa-go would be useful. I appreciate we're moving away from having the CLI to define their own mocks, but I noticed some other UX changes (messaging, etc) that would be great to detail. Let me know if I can help with this. |
janelletavares
force-pushed
the
janelle_docs
branch
from
2ddc6b1 to
46751ea
Compare
Here are the related PRs, if that helps. |
There was a problem hiding this comment.
Thank you @janelletavares for providing those links with changes made in meroxa-go. I still have some questions to what seem to be changing publicly documented flags (metadata, and some expected behavior when creating connectors via meroxa connect).
Let's pair if you think I'm still missing some context.
| }, | ||
| Metadata: map[string]interface{}{}, |
There was a problem hiding this comment.
How come we're no longer comparing on Metadata?
There was a problem hiding this comment.
The value we put in isn't the totality of the value we get out, so it got messy. there may be a way to adjust for that, i didn't spend a lot of time on it.
| }, | ||
| Metadata: map[string]interface{}{}, |
There was a problem hiding this comment.
The value we put in isn't the totality of the value we get out, so it got messy. there may be a way to adjust for that, i didn't spend a lot of time on it.
|
@janelletavares Working on the CLI today I realized I'm blocked on some changes made in If we could have only one pull-request that could make the CLI work with the latest of meroxa-go would be great, thank you. |
|
@raulb if the meroxa-go PR and this PR seem good to you, feel free to squash merge, update the go.mod to unblock you. |
There was a problem hiding this comment.
This LGTM now. We'll evaluate removing the metadata flag in a separate pull-request following the usual process:
- Check usage of this flag to determine a deprecation path (or simply removing it if it hasn't been used)
- Depending on 1, hide flag, set a deprecation date to remove it altogether
- Remove support in meroxa-go
Description of change
absorb new meroxa-go interface; small doc changes
Fixes
Type of change
How was this tested?
Demo
Before this pull-request
Include how it looked before
After this pull-request
Include how it looks now
Additional references
Any additional links (if appropriate)
Documentation updated
Make sure that our documentation is accordingly updated when necessary.
You can do that by opening a pull-request to our (🔒 private, for now) repository: https://github.com/meroxa/meroxa-docs.
✨ In the future, there will be a GitHub action taking care of these updates automatically. ✨
Provide PR link: