feat: Update user info every 24h and adds command with feature flag #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It starts storing `USER_FEATURE_FLAGS` existing feature flags
raulb
changed the title
raulb
force-pushed
the
rb/feature-flags
branch
2 times, most recently
from
7a09af8 to
11c48d0
Compare
raulb
force-pushed
the
rb/feature-flags
branch
from
11c48d0 to
79d1d86
Compare
lovromazgon
reviewed
Sep 28, 2021
cmd/meroxa/builder/builder.go
Outdated
Comment on lines
629
to
635
| flagRequired := v.FeatureFlag() | ||
| userFeatureFlags := global.Config.GetStringSlice(global.UserFeatureFlagsEnv) | ||
|
|
||
| if !hasFeatureFlag(userFeatureFlags, flagRequired) { | ||
| return fmt.Errorf("your account does not have access to the %q feature. Reach out to [email protected] for more information", flagRequired) | ||
| } |
There was a problem hiding this comment.
Can this be moved outside of the PreRunE function? I think we already have all the info at that point, don't we? If we do, then we could already detect if the feature flag is enabled and un-hide the command (cmd.Hidden = false).
There was a problem hiding this comment.
For context, @lovromazgon and I paired today to explore this option and we both agreed that the effort to make it work is currently not worth it. Maybe in a future iteration we'll revisit this.
dianadoherty
approved these changes
Sep 28, 2021
Co-authored-by: Diana Doherty <[email protected]>
raulb
force-pushed
the
rb/feature-flags
branch
from
619d48b to
c7011fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This pull-request adds the ability to create a CLI command that depends on a Meroxa User Feature Flag. These are returned by the API endpoint
/v1/users/meand when that API endpoint is used inmeroxa whoamiwe also make sure we update this information.To make sure user information is not stale, we'll start fetching this information every 24hours since last time was updated.
To demo the usage of feature flags, this pull-request also adds the
environmentcommand which could aliased asenvorenvironment.Fixes https://github.com/meroxa/product/issues/113
Depends on https://github.com/meroxa/meroxa-go/pull/53.Type of change
How was this tested?
Demo
Before this pull-request
After this pull-request
Without feature flag enabled
With feature flag enabled