Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make pipeline required on connect #191

Merged
merged 4 commits into from
Sep 9, 2021
Merged

Conversation

raulb
Copy link
Member

@raulb raulb commented Sep 8, 2021

Description of change

Fixes https://github.com/meroxa/product/issues/128

Continuation of #189.

It also updates the wording to make it more specific when creating a connector within the context of a pipeline.

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Unit Tests
  • Tested in staging

Demo

Before this pull-request

$ meroxa connect --input my-resource.Table --config '{"key":"value"}' --pipeline my-pipeline --source resource-1234 --destination resource-4567
Creating connector from source "resource-1234"...
Creating connector to destination "resource-4567"...
Source connector "connector-1234" and destination connector "connector-4567" successfully created!

After this pull-request

$ meroxa connect --input my-resource.Table --config '{"key":"value"}' --pipeline my-pipeline --source resource-1234 --destination resource-4567
Creating connector from source "resource-1234" in pipeline "my-pipeline"...
Creating connector to destination "resource-4567" in pipeline "my-pipeline"...
Source connector "connector-1234" and destination connector "connector-1234" successfully created!

Documentation updated

https://github.com/meroxa/meroxa-docs/pull/37

Fixes meroxa/product#128

It also makes ID to be a valid input when creating pipelines
I believe this should be changed everywhere so users know accurately when it can be an ID or not.
Something I forgot to push in #189 :hide:
@raulb raulb requested a review from dianadoherty September 8, 2021 11:36
@raulb raulb self-assigned this Sep 8, 2021
@raulb raulb requested a review from dianadoherty September 8, 2021 15:54
@raulb raulb merged commit c3b555b into master Sep 9, 2021
@raulb raulb deleted the raul/pipeline-required branch September 9, 2021 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants