Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Env: Functions Support] Consolidate sources endpoint and use v2 only #664

Closed
raulb opened this issue Mar 27, 2023 · 0 comments · Fixed by #666
Closed

[Env: Functions Support] Consolidate sources endpoint and use v2 only #664

raulb opened this issue Mar 27, 2023 · 0 comments · Fixed by #666
Assignees
@anna-cross

Comments

@raulb
Copy link
Member

raulb commented Mar 27, 2023 •
edited
Loading

Update CLI endpoint for creating sources and always use v2 regardless of sending environment or not:

cli/cmd/meroxa/root/apps/deploy.go

Lines 63 to 64 in 6d8bea3

CreateSource(ctx context.Context) (*meroxa.Source, error)
CreateSourceV2(ctx context.Context, input *meroxa.CreateSourceInputV2) (*meroxa.Source, error)

⚠️ The importance here is to make sure the API path for this endpoint is clearer when no environments is provisioned.

ℹ️ Part of this EPIC
@raulb raulb changed the title [Env: Functions Support] [Env: Functions Support] Consolidate sources endpoint and use v2 only Mar 27, 2023
@anna-cross anna-cross self-assigned this Mar 27, 2023
@anna-cross anna-cross mentioned this issue Mar 28, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anna-cross anna-cross

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Always use v2 Source endpoint on App Deploy meroxa/cli
2 participants
@raulb @anna-cross