progress after testing

cmd/meroxa/root/environments/create.go

@@ -18,6 +18,7 @@ package environments
 
 import (
 	"context"
+	"encoding/json"
 	"errors"
 	"fmt"
 	"strings"
@@ -129,25 +130,33 @@ func (c *Create) Execute(ctx context.Context) error {
 	c.logger.Infof(ctx, "Provisioning environment...")
 
 	environment, err := c.client.CreateEnvironment(ctx, e)
+	fmt.Printf("err: %+v\n", err)
+	fmt.Printf("env: %+v\n", environment)
 
 	if err != nil {
-		c.logger.JSON(ctx, environment.Status.State)
-		if environment.Status.State == meroxa.EnvironmentStatePreflightError {
-			c.logger.JSON(ctx, environment.Status.PreflightDetails)
-		}
 		return err
 	}
 
-	c.logger.Infof(ctx, "Environment %q is being provisioned. Run `meroxa env describe %s` for status", environment.Name, environment.Name)
-
-	if environment.Status.State == meroxa.EnvironmentStatePreflightSuccess {
+	if environment.Status.State == meroxa.EnvironmentStatePreflightError {
+		details, _ := prettyString(environment.Status.PreflightDetails)
+		c.logger.Errorf(ctx, "Environment %q could not be provisioned because it failed the preflight checks\n%s\n", environment.Name, details)
+	} else if environment.Status.State == meroxa.EnvironmentStatePreflightSuccess {
 		environment.Status.PreflightDetails = nil
+		c.logger.Infof(ctx, "Preflight checks have passed. Environment %q is being provisioned. Run `meroxa env describe %s` for status", environment.Name, environment.Name)
 	}
 
 	c.logger.JSON(ctx, environment)
 	return nil
 }
 
+func prettyString(a interface{}) (string, error) {
+	j, err := json.MarshalIndent(a, "", "  ")
+	if err != nil {
+		return "", err
+	}
+	return string(j), nil
+}
+
 func (c *Create) NotConfirmed() string {
 	return "\nTo view all options for creating a Meroxa Environment,\n " +
 		"please run \"meroxa help env create\". \n"

utils/display.go

@@ -597,7 +597,7 @@ func EnvironmentTable(environment *meroxa.Environment) string {
 			{Text: strings.Join(environment.Status.PreflightDetails.PreflightPermissions.S3, " ; ")},
 		},
 		{
-			{Align: simpletable.AlignRight, Text: "AWS Service Quotas Permissions Status:"},
+			{Align: simpletable.AlignRight, Text: "AWS ServiceQuotas Permissions Status:"},
 			{Text: strings.Join(environment.Status.PreflightDetails.PreflightPermissions.ServiceQuotas, " ; ")},
 		},
 		{

utils/tests.go

@@ -139,12 +139,12 @@ func GenerateEnvironmentFailed(environmentName string) meroxa.Environment {
 		Status: meroxa.EnvironmentViewStatus{
 			State:   meroxa.EnvironmentStatePreflightError,
 			Details: "",
-			PreflightDetails: meroxa.PreflightDetails{
-				PreflightPermissions: meroxa.PreflightPermissions{
+			PreflightDetails: &meroxa.PreflightDetails{
+				PreflightPermissions: &meroxa.PreflightPermissions{
 					S3:  []string{"missing read permission for S3", "missing write permissions for S3"},
 					EC2: []string{"missing read permission for S3", "missing write permissions for S3"},
 				},
-				PreflightLimits: meroxa.PreflightLimits{
+				PreflightLimits: &meroxa.PreflightLimits{
 					EIP: "",
 				},
 			},