-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
semicolons, anyone? #111
Comments
Semicolons are optional and not necessary for the graph. You use them or not is completely your choice and it should not break the parsing of the graph. For the remaining issues, others will give you a more detailed explanation. |
I think this is a versioning issue. Initially the semicolons were required. Later after some much appreciated input the semicolons are now optional. So if the lighttable plugin requires them (;) it means that an older version of version of mermaid is used. Would they upgrade the version the behaviour of mermaid would change. Not to hard for the plugin maker so perhaps a good thing to propose to them... I am working on a syntax for simplifying detecting the version if mermaid. The syntax will be something like:
Which will create a diagram displaying the version of mermaid. This is simplify things going forward but is not yet released and it will certainly ot work in the older versions of mermaid :) |
@clojens I hope this has been clarified. Please reopen the issue if your problem persists. |
@knsv Thanks for the clarification, I'll know to keep an eye for any API/syntactic changes in that case. And yeah, the update is trivial so we'll manage I think ;) Cheers |
Am I the only one who has every non-trivial sample in the demo's / syntax guide fail? Breaking changes or? For one, I get the impression semicolons are enforced yet the examples all omit them. Then the -- text -- connectors, none working. Hmmm... strangely enough the plugin developed by cldwalker in Light Table (https://github.com/cldwalker/lt-mermaid) but also the online editor (http://www.naseer.in/mermaid-webapp/) posted seem to have wildly different ideas about what is correct syntax. What works in one, doesn't work in the other. Whats up with this exactly? Some behind in their dependencies? Messy/failing code? Ambiguous grammar? Or me being extremely stupid... I'd be interested to learn :) I don't mind digging in the code a bit later when I have time but its a bit of a fluke that the demo/examples seem so hard to reproduce. If I'm overlooking some piece of information or anything: its probably not obvious enough,... lol
The text was updated successfully, but these errors were encountered: