From 85fb12155bf1ac4973f702d170f98ed71ff7ebab Mon Sep 17 00:00:00 2001 From: Michael Bodnarchuk Date: Tue, 24 Dec 2019 00:08:38 +0200 Subject: [PATCH 1/3] Create checks.yml (#1) * Create checks.yml * Update checks.yml --- .github/workflows/checks.yml | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) create mode 100644 .github/workflows/checks.yml diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml new file mode 100644 index 0000000000..bc60f59777 --- /dev/null +++ b/.github/workflows/checks.yml @@ -0,0 +1,19 @@ +on: [push] + +name: Static analysis + +jobs: + test: + runs-on: ubuntu-latest + name: check tests + steps: + - uses: actions/checkout@v2 + with: + fetch-depth: 0 + - uses: testomatio/check-tests@stable + with: + framework: cypress + tests: "./cypress/integration/**/**.spec.js" + token: ${{ secrets.GITHUB_TOKEN }} + has-tests-label: true + From 4eedeebd4660b55cf68586f0430f548845af2f1a Mon Sep 17 00:00:00 2001 From: wfnuser Date: Tue, 24 Dec 2019 12:57:55 +0800 Subject: [PATCH 2/3] other/typos in flowDb --- src/diagrams/flowchart/flowDb.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/diagrams/flowchart/flowDb.js b/src/diagrams/flowchart/flowDb.js index 11e7ebf6cb..4398bf7e2c 100644 --- a/src/diagrams/flowchart/flowDb.js +++ b/src/diagrams/flowchart/flowDb.js @@ -65,7 +65,7 @@ export const addVertex = function(_id, text, type, style, classes) { if (typeof text !== 'undefined') { txt = sanitize(text.trim()); - // strip quotes if string starts and exnds with a quote + // strip quotes if string starts and ends with a quote if (txt[0] === '"' && txt[txt.length - 1] === '"') { txt = txt.substring(1, txt.length - 1); } From 728e3fd2f0af6660e4e64305682822573e50f389 Mon Sep 17 00:00:00 2001 From: Christian Klemm Date: Tue, 24 Dec 2019 23:37:18 +0100 Subject: [PATCH 3/3] Added task list to pull request template --- .github/pull_request_template.md | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 952020fc8d..d1ae7edec7 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,7 +1,13 @@ -## Summary +## :bookmark_tabs: Summary Brief description about the content of your PR. -## Design Decisions +Resolves # + +## :straight_ruler: Design Decisions Describe the way your implementation works or what design decisions you made if applicable. -Resolves # +### :clipboard: Tasks +Make sure you +- [ ] :book: have read the [contribution guidelines](https://github.com/mermaid-js/mermaid/blob/develop/CONTRIBUTING.md) +- [ ] :computer: have added unit/e2e tests (if appropriate) +- [ ] :bookmark: targeted `develop` branch