Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade mermaid to 10.9.0 (Latex support) #680

Closed
maikol-solis opened this issue Apr 11, 2024 · 2 comments · Fixed by #685
Closed

Upgrade mermaid to 10.9.0 (Latex support) #680

maikol-solis opened this issue Apr 11, 2024 · 2 comments · Fixed by #685

Comments

@maikol-solis
Copy link

Describe the bug

The new latest mermaid 10.9.0 has Latex support. mermaid-cli is still in version 10.8.0.

Merging the PR #663 will do it.

Best.

@MindaugasLaganeckas
Copy link
Member

Switch to 10.9.0 is blocked by broken regression suite.

@aloisklink
Copy link
Member

Mermaid v10.9.0 greatly increases the size of the bundle, and that seems to be causing issues with tests.

I'm looking into a way of fixing it but my gut feeling is that it might be a bit of work, since we might need to dig into Puppeteer internals to support splitting up the bundle into multiple parts, without triggering CSP/CORs errors.

This comment puppeteer/puppeteer#1229 (comment) looks promising!

Unfortunately, I haven't really had the free time to look at for the past few weeks, since I've been ill, but I'll see if I can get a chance to look at in the next few days! Otherwise, help would be appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants