Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: window.baseurl is not working in all the cases to fix this using window.location.pathname #1041

Merged
merged 3 commits into from
Oct 25, 2023
Merged

bugfix: window.baseurl is not working in all the cases to fix this using window.location.pathname #1041

merged 3 commits into from
Oct 25, 2023

Conversation

glg-satish-tripathi
Copy link
Contributor

@glg-satish-tripathi glg-satish-tripathi commented Oct 25, 2023 •
edited
Loading

bugfix:

  • The window.baseurl is not working as expected as in some cases window.baseurl is undefined.
  • using window.location.pathname is better then using window.baseurl as in some cases the value is undefined.

@glg-satish-tripathi glg-satish-tripathi changed the title Fix baseurl bugfix: window.baseurl is not working in all the cases to fix this using window.location.pathname Oct 25, 2023
mcollina
mcollina approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 8fd5f1e into mercurius-js:master Oct 25, 2023
10 checks passed
@glg-satish-tripathi glg-satish-tripathi mentioned this pull request Oct 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glg-satish-tripathi @mcollina