Teach ts sdk about product utility members #236
Conversation
| throw new Error("company is undefined, did you forget to embed it?"); | ||
| } | ||
| if (this.company.defaultCurrency === undefined) { | ||
| const err = "company.defaultCurrency is undefined, did you forget to" + |
There was a problem hiding this comment.
default currency is a primary variable how can it not be embeded
| } | ||
|
|
||
| public taxType = () => { | ||
| if (this.domain === undefined) { |
There was a problem hiding this comment.
can wrap in a function checkDomainEmbeded()
There was a problem hiding this comment.
not until typescript supports "assertion signatures" (i.e., 3.7)
| } | ||
|
|
||
| public hasGroupVariationFields = () => { | ||
| if (this.groupVariationFields === undefined) { |
There was a problem hiding this comment.
ideally can be warp in a function checkEmbeded(this.groupVariationFields) or do some magic on property annotations.
Not required for this pr, but just raise this issue #241
| const variationFields = variationField.independent ? | ||
| this.independentVariationFields : this.groupVariationFields; | ||
| const index = variationFields.findIndex(v => { | ||
| if (v.id === undefined) { |
There was a problem hiding this comment.
how could a miss embed cause variation.id to be null.
| } | ||
|
|
||
| public buildEmptyVariation = () => { | ||
| if (this.defaultValue === undefined) { |
There was a problem hiding this comment.
how could a embed missing lead to undefined "defaultValue"
| if (this.defaultValue === undefined) { | ||
| throw new Error("defaultValue is undefined, did you forget to embed it?"); | ||
| } | ||
| if (this.variationCost === undefined) { |
There was a problem hiding this comment.
how could a embed missing lead to undefined "variationCost"
| for (const option of this.options) { | ||
| if (option.default) { | ||
| if (option.variationCost === undefined) { | ||
| throw new Error("option.variationCost is undefined, did you " + |
There was a problem hiding this comment.
same suspection why do embed check on primary value
There was a problem hiding this comment.
OK, the error suggestion is bad, it's unlikely to be from a missed embed.
the situation will more likely arise due creating a new object that hasn't fetched anything at all from the server yet.
|
as currently our sdk is only used internally, I think the error does not matter that much as long as we know what we are doing |
No description provided.