Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce the code for "not embed check" #241

Open
s3341458 opened this issue Oct 2, 2019 · 1 comment
Open

reduce the code for "not embed check" #241

s3341458 opened this issue Oct 2, 2019 · 1 comment
Labels
question Further information is requested

Comments

@s3341458
Copy link
Collaborator

s3341458 commented Oct 2, 2019

I see something like

if (this.featureImage === undefined) {
throw new Error("featureImage is undefined, did you forget to embed it?");
}
if (this.images === undefined) {
throw new Error("images is undefined, did you forget to embed it?");
}

Hope we can reduce some code for this.

@s3341458 s3341458 added the question Further information is requested label Oct 2, 2019
@DanielCollins
Copy link
Contributor

https://devblogs.microsoft.com/typescript/announcing-typescript-3-7-beta/

wait for "assertion signatures" in ts 3.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants