-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No Github comments from tfnotify #120
Comments
I am facing similar problems and tfnotify is not setting any lanes either... |
I got this to work locally but for some reason tfnotify insists on posting commit comments instead of pull request comments for the exact same environment variables set. |
@Starefossen what do you mean exactly? I also get the commit's comments instead of pull request's comments but still no PR labels. Can you provide here the command you run? |
I compiled it myself, didn't realize that the "latest" version was so far behind master branch. |
You can use the tfnotify binary I have compiled from here: https://github.com/nais/tfnotify/releases/tag/v0.7.8 |
I also made #121 to fix the build and release so they can get a new version out. |
My issue:
Even though I set
GITHUB_REF
env var, I still gettfnotify
comments attached to my commits instead of having them attached to related PR and what's more I do not get any labels attached to my PR.My
tfnotify.yml
The command I run as part of my local tests:
I have a feeling tfnotify does not respect the GITHUB_REF env var I set and hence this code does not get executed.
The text was updated successfully, but these errors were encountered: