Create california housing dataset #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 24, 2022 13:19
5 tasks
winfried-ripken
approved these changes
Sep 26, 2022
src/squirrel_datasets_core/datasets/california_housing/README.rst
Outdated
Show resolved
Hide resolved
AlirezaSohofi
approved these changes
Sep 27, 2022
| ] | ||
|
|
||
|
|
||
| class CaliforniaHousing(IterDriver): |
There was a problem hiding this comment.
we could inherit from CsvDriver here, downside would be that would requires dask which is not needed in this case, but you can also overwrite the get_df method which would resolve this.
There was a problem hiding this comment.
I think I'd prefer not to have to get the full dask dependency for this. Seems like an overkill.
…_.py Co-authored-by: Alireza Sohofi <[email protected]>
Co-authored-by: Winfried Ripken <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.
Fixes # issue
Type of change
Checklist: