-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make the split_by_worker and slpit_by_rank optional #140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid, but I am not exactly sure which problem this is solving. Is it possible to include an example for combining sources in a driver in the docs and mention how using this configuration is necessary?
4d8191b
to
caa3481
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ali, Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This is PR is marked as stale as it has been inactive for 30 days. It will be closed in 7 days. |
7d6836b
to
6db8b7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thks, lgtm!
Description
The requirements: merging multiple streams in a single driver, while ensuring data splitting happens at the shard key level. In this case, the user will take care that the correct splitting logic is indeed applied to each stream, still the drivers that includes these streams can't figure out if this is the case. By providing a way to bypass this safety mechanism, power users can build more powerful pipelines.
Fixes # issue
Type of change
Checklist: