Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve dependabot alerts #129

Merged
merged 4 commits into from
Jul 19, 2023
Merged

resolve dependabot alerts #129

merged 4 commits into from
Jul 19, 2023

Conversation

pzdkn
Copy link
Contributor

@pzdkn pzdkn commented Jul 11, 2023

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.

Fixes # issue

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring including code style reformatting
  • Other (please describe):

Checklist:

  • I have read the contributing guideline doc (external contributors only)
  • Lint and unit tests pass locally with my changes
  • I have kept the PR small so that it can be easily reviewed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • All dependency changes have been reflected in the pip requirement files.

@pzdkn pzdkn requested a review from AlirezaSohofi July 11, 2023 08:43
@@ -42,7 +42,7 @@ pyxlsb = {version = "^1.0.10", optional = true}
xlrd = {version = "^2.0.1", optional = true}
gcsfs = {version = ">=2021.7.0", optional = true}
s3fs = {version = ">=2021.7.0", optional = true}
torch = {version = "^1.13.1", optional = true}
torch = {version = ">=1.13.1", optional = true}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 31, numba should be marked as optional, right?

@AlirezaSohofi AlirezaSohofi self-requested a review July 19, 2023 15:54
@AlirezaSohofi AlirezaSohofi merged commit 276a1cc into main Jul 19, 2023
@AlirezaSohofi AlirezaSohofi deleted the peng-update-dependencies branch July 19, 2023 15:54
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants