Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit import statement in FileDriver docs #124

Merged
merged 1 commit into from
May 26, 2023
Merged

Edit import statement in FileDriver docs #124

merged 1 commit into from
May 26, 2023

Conversation

LisaCoiffard
Copy link
Contributor

@LisaCoiffard LisaCoiffard commented May 26, 2023 •
edited
Loading

Description

Changed a wrong import statement in driver docs for FileDriver.

Fixes # issue

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring including code style reformatting
  • Other (please describe):

Checklist:

  • I have read the contributing guideline doc (external contributors only)
  • Lint and unit tests pass locally with my changes
  • I have kept the PR small so that it can be easily reviewed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • All dependency changes have been reflected in the pip requirement files.

@LisaCoiffard LisaCoiffard requested a review from pzdkn May 26, 2023 08:54
@github-actions
Copy link

github-actions bot commented May 26, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@LisaCoiffard
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@LisaCoiffard
Copy link
Contributor Author

recheck

github-actions bot added a commit that referenced this pull request May 26, 2023
@github-actions
@LisaCoiffard has signed the CLA from Pull Request #124
7136173
pzdkn
pzdkn approved these changes May 26, 2023
View reviewed changes
Copy link
Contributor

@pzdkn pzdkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thanks, lgtm

@LisaCoiffard LisaCoiffard merged commit 15dd10d into main May 26, 2023
@LisaCoiffard LisaCoiffard deleted the lisa-driver-docs branch May 26, 2023 09:13
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pzdkn pzdkn pzdkn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LisaCoiffard @pzdkn