Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pypi classifiers #10

Merged
merged 2 commits into from
Mar 11, 2022
Merged

add pypi classifiers #10

merged 2 commits into from
Mar 11, 2022

Conversation

TiansuYu
Copy link
Contributor

Description

Add pypi classifiers to prevent uploading to public pypi (this does not affect test_pypi server).

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring including code style reformatting
  • Other (please describe):

Checklist:

  • Lint and unit tests pass locally with my changes
  • I have kept the PR small so that it can be easily reviewed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • All dependency changes have been reflected in the pip requirement files.

AlpAribal
AlpAribal approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@AlpAribal AlpAribal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

setup.py
classifiers = [
"Private :: Do Not Upload",
"Development Status :: 4 - Beta",
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about also adding:

  • License :: OSI Approved :: Apache Software License
  • Programming Language :: Python :: 3.8
  • Typing :: Typed

@TiansuYu TiansuYu merged commit 57cac70 into main Mar 11, 2022
@TiansuYu TiansuYu deleted the tiansu-add-pypi-classifiers branch March 11, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlpAribal AlpAribal AlpAribal approved these changes

@ThomasWollmann ThomasWollmann Awaiting requested review from ThomasWollmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TiansuYu @AlpAribal