Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement Enable relative path for OpenID Provider #358

Closed
precoder opened this issue Oct 22, 2020 · 1 comment
Closed

Enhancement Enable relative path for OpenID Provider #358

precoder opened this issue Oct 22, 2020 · 1 comment

Comments

@precoder
Copy link
Contributor

Hello,
We have made a few derivations on our copy from the upstream.
We want to share them with you so if you find them useful you can also benefit from the code changes.

This is the 2nd of 4 changes.

Motivation:
Enable Membrane to start on a relative path,
so it can be chained under another reverse proxy such as Ngnix.

@DJGummikuh
Copy link

A little bit on detail for this one as well:
We're running membrane as reverse-proxy, SSL Terminator, webserver and OIDC Provider.
Since our software contains a web client we wanted to provide that one under /, while restrictive network policies of customers as well as CORS considerations prompted us towards making the OIDC provider accessible under the same port as everything else.

This change request allows you to put the login into OIDC anywhere (while not removing the ability to place it under /).
This allows us to have the following endpoint structure:
/ - web client
/api - Backend endpoints
/auth - Login service (login mask, callback, well-known config etc.)

@rrayst rrayst closed this as completed in 797ed97 Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants