Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(targets): Allow overriding the bulk insert statement in SQLSink #908

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Aug 12, 2022

Small improvement towards #9

@edgarrmondragon edgarrmondragon self-assigned this Aug 12, 2022
@edgarrmondragon edgarrmondragon changed the title refactor: Allow overriding the bulk insert statement refactor(targets): Allow overriding the bulk insert statement in SQLSink Aug 12, 2022
@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #908 (4b5ff66) into main (cc7e06d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #908      +/-   ##
==========================================
+ Coverage   80.31%   80.33%   +0.02%     
==========================================
  Files          34       34              
  Lines        3413     3418       +5     
  Branches      679      679              
==========================================
+ Hits         2741     2746       +5     
  Misses        499      499              
  Partials      173      173              
Impacted Files Coverage Δ
singer_sdk/sinks/sql.py 78.94% <100.00%> (+1.48%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon force-pushed the refactor/allow-insert-statement-override branch 2 times, most recently from d292cc3 to 3b77287 Compare August 12, 2022 18:49
@edgarrmondragon edgarrmondragon force-pushed the refactor/allow-insert-statement-override branch from 3b77287 to 4b5ff66 Compare August 12, 2022 19:09
@edgarrmondragon edgarrmondragon marked this pull request as ready for review August 12, 2022 19:28
Copy link
Contributor

@aaronsteers aaronsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'd just like to tweak the PR title slightly to make release notes easier to scan in future.

@aaronsteers
Copy link
Contributor

Scratch my comment about the PR title. It looks great as is. I was reading from my mobile app and was looking in the wrong place.

@edgarrmondragon edgarrmondragon merged commit 067df67 into main Aug 12, 2022
@edgarrmondragon edgarrmondragon deleted the refactor/allow-insert-statement-override branch August 12, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants