-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Generate documentation for constructor parameters #900
docs: Generate documentation for constructor parameters #900
Conversation
Codecov Report
@@ Coverage Diff @@
## main #900 +/- ##
=======================================
Coverage 80.31% 80.31%
=======================================
Files 34 34
Lines 3413 3413
Branches 679 679
=======================================
Hits 2741 2741
Misses 499 499
Partials 173 173 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to render both the signatures and the detailed parameter / return value content? If so I think that would be ideal. In either case, this looks good to me.
@WillDaSilva good idea! I think I've solved that now by explicitly requesting |
090b18c
to
594c2f3
Compare
…ot-added-to-generated-autodocs
@edgarrmondragon Could you please provide an updated preview link? I'm not sure how you generated it - I don't see any CI actions for it. |
@WillDaSilva It's up-to-date with the changes in this PR. Builds are triggered in readthedocs but it's failing to report back to GitHub in the PR checks. |
nox
task for live-reloading docs.Current state: https://sdk.meltano.com/en/latest/classes/singer_sdk.Stream.html#singer_sdk.Stream
vs
Preview: https://meltano-sdk--900.org.readthedocs.build/en/900/classes/singer_sdk.Stream.html#singer_sdk.Stream