Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix typo RecordsWitoutSchemaException -> RecordsWithoutSchemaException #856

Merged
merged 2 commits into from
Sep 1, 2022
Merged

fix: Fix typo RecordsWitoutSchemaException -> RecordsWithoutSchemaException #856

merged 2 commits into from
Sep 1, 2022

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jul 23, 2022 •
edited
Loading

Closes #846

@edgarrmondragon edgarrmondragon linked an issue Jul 23, 2022 that may be closed by this pull request
Misspelling exceptions.RecordsWitoutSchemaException #846
Closed
@edgarrmondragon edgarrmondragon self-assigned this Jul 23, 2022
@edgarrmondragon
Copy link
Collaborator Author

Updated docs: https://meltano-sdk--856.org.readthedocs.build/en/856/classes/singer_sdk.exceptions.RecordsWithoutSchemaException.html

@codecov
Copy link

codecov bot commented Jul 23, 2022 •
edited
Loading

Codecov Report

Merging #856 (0bf7a29) into main (1430f7c) will not change coverage.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             main     #856   +/-   ##
=======================================
  Coverage   81.25%   81.25%           
=======================================
  Files          36       36           
  Lines        3543     3543           
  Branches      712      712           
=======================================
  Hits         2879     2879           
  Misses        489      489           
  Partials      175      175
Impacted Files Coverage Δ
singer_sdk/target_base.py 85.02% <50.00%> (ø)
singer_sdk/exceptions.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon force-pushed the 846-misspelling-exception branch from 3382a20 to ed536a8 Compare September 1, 2022 00:13
@edgarrmondragon edgarrmondragon marked this pull request as ready for review September 1, 2022 00:23
@edgarrmondragon edgarrmondragon merged commit e19ecf5 into main Sep 1, 2022
@edgarrmondragon edgarrmondragon deleted the 846-misspelling-exception branch September 1, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronsteers aaronsteers aaronsteers approved these changes

@cjohnhanson cjohnhanson Awaiting requested review from cjohnhanson

Assignees

@edgarrmondragon edgarrmondragon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Misspelling exceptions.RecordsWitoutSchemaException
2 participants
@edgarrmondragon @aaronsteers