Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure the required global folder tap settings are merged into the concrete implementation settings #2790

Merged

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Dec 2, 2024

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/fix/merge-required-settings-folder-tap branch from ed03f81 to d9648f5 Compare December 2, 2024 15:51
Copy link

codspeed-hq bot commented Dec 2, 2024

CodSpeed Performance Report

Merging #2790 will not alter performance

Comparing edgarrmondragon/fix/merge-required-settings-folder-tap (2d6b36f) with main (0ac558a)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.24%. Comparing base (0ac558a) to head (2d6b36f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2790      +/-   ##
==========================================
+ Coverage   91.12%   91.24%   +0.12%     
==========================================
  Files          62       62              
  Lines        5181     5184       +3     
  Branches      669      668       -1     
==========================================
+ Hits         4721     4730       +9     
+ Misses        325      321       -4     
+ Partials      135      133       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review December 2, 2024 16:39
@edgarrmondragon edgarrmondragon merged commit edcbb1a into main Dec 2, 2024
36 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/fix/merge-required-settings-folder-tap branch December 2, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant