Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(targets): Added a new built-in setting activate_version for targets to optionally disable processing of ACTIVATE_VERSION messages #2784

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Nov 29, 2024

Copy link

codspeed-hq bot commented Nov 29, 2024

CodSpeed Performance Report

Merging #2784 will not alter performance

Comparing 2776-a-new-setting-meant-to-ignore-activate_version-messages-entirely (0edb118) with main (a553c38)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.12%. Comparing base (a553c38) to head (0edb118).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2784      +/-   ##
==========================================
+ Coverage   91.02%   91.12%   +0.09%     
==========================================
  Files          62       62              
  Lines        5170     5181      +11     
  Branches      666      669       +3     
==========================================
+ Hits         4706     4721      +15     
+ Misses        326      325       -1     
+ Partials      138      135       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the 2776-a-new-setting-meant-to-ignore-activate_version-messages-entirely branch 3 times, most recently from d3ea408 to 0940f57 Compare November 30, 2024 00:10
@edgarrmondragon edgarrmondragon force-pushed the 2776-a-new-setting-meant-to-ignore-activate_version-messages-entirely branch from 0940f57 to e8adcad Compare November 30, 2024 03:17
@edgarrmondragon edgarrmondragon self-assigned this Nov 30, 2024
@edgarrmondragon edgarrmondragon added the Type/Target Singer targets label Nov 30, 2024
@edgarrmondragon edgarrmondragon added this to the v0.43 milestone Nov 30, 2024
@edgarrmondragon edgarrmondragon marked this pull request as ready for review December 2, 2024 03:48
@edgarrmondragon edgarrmondragon merged commit 0ac558a into main Dec 2, 2024
36 checks passed
@edgarrmondragon edgarrmondragon deleted the 2776-a-new-setting-meant-to-ignore-activate_version-messages-entirely branch December 2, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type/Target Singer targets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A new setting meant to ignore ACTIVATE_VERSION messages entirely
1 participant