Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Mapped datetime values are now typed as date-time strings in the schema message #2665

Merged

Conversation

gregkoutsimp
Copy link
Contributor

@gregkoutsimp gregkoutsimp commented Sep 11, 2024

When generating a datetime value from a string using stream map functionality, the detected schema type for the value falls back to string.

In this implementation we extend _eval_type method of class CustomStreamMap from the mapper.py to be bale to process dates and datetimes data types in stream maps.

Closes #1695


📚 Documentation preview 📚: https://meltano-sdk--2665.org.readthedocs.build/en/2665/

Copy link

codspeed-hq bot commented Sep 11, 2024

CodSpeed Performance Report

Merging #2665 will not alter performance

Comparing gregkoutsimp:1695_bug_fix_datetype_stream_maps (3281177) with main (6b3869d)

Summary

✅ 6 untouched benchmarks

@edgarrmondragon edgarrmondragon changed the title Mapped datetime values are typed as strings in the schema message BUG1695 fix: Mapped datetime values are now typed as date-time strings in the schema message Sep 11, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.86%. Comparing base (6b3869d) to head (3281177).
Report is 112 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2665      +/-   ##
==========================================
+ Coverage   89.82%   89.86%   +0.04%     
==========================================
  Files          58       58              
  Lines        4886     4886              
  Branches      960      960              
==========================================
+ Hits         4389     4391       +2     
+ Misses        346      344       -2     
  Partials      151      151              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gregkoutsimp!

@edgarrmondragon edgarrmondragon added this pull request to the merge queue Sep 11, 2024
Merged via the queue into meltano:main with commit 998083a Sep 11, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Mapped datetime values are typed as strings in the schema message
2 participants